RFR [13] JDK-8218889: Improperly use of the Optional API

Jamil Nimeh jamil.j.nimeh at oracle.com
Fri Mar 22 16:41:59 UTC 2019


This looks fine to me.

--Jamil

On 3/22/19 9:39 AM, Xuelei Fan wrote:
> Hi,
>
> Could I have the following update reviewed:
>     http://cr.openjdk.java.net/~xuelei/8218889/webrev.00/
>
> In general Optional is a good option.  However, 
> Optional.ofNullable​(null).get() throws NoSuchElementException, as 
> limit the benefits to use Optional.ofNullable​() for null object in 
> the session management context.   With this update, the Optional is 
> replaced with other coding conventions.
>
> Code cleanup, no new regression test.
>
> Thanks,
> Xuelei



More information about the security-dev mailing list