RFR [13] JDK-8218889: Improperly use of the Optional API

Bradford Wetmore bradford.wetmore at oracle.com
Fri Mar 22 17:40:22 UTC 2019


+1.

I noticed this earlier while looking at my other work, and was wondering 
if this was a new style that I had missed.

Thanks,

Brad


On 3/22/2019 9:41 AM, Jamil Nimeh wrote:
> This looks fine to me.
> 
> --Jamil
> 
> On 3/22/19 9:39 AM, Xuelei Fan wrote:
>> Hi,
>>
>> Could I have the following update reviewed:
>>     http://cr.openjdk.java.net/~xuelei/8218889/webrev.00/
>>
>> In general Optional is a good option.  However, Optional.ofNullable​ 
>> (null).get() throws NoSuchElementException, as limit the benefits to 
>> use Optional.ofNullable​() for null object in the session management 
>> context.   With this update, the Optional is replaced with other 
>> coding conventions.
>>
>> Code cleanup, no new regression test.
>>
>> Thanks,
>> Xuelei



More information about the security-dev mailing list