[15] RFR: 8242335: Additional Tests for RSASSA-PSS

Valerie Peng valerie.peng at oracle.com
Thu Apr 30 23:28:06 UTC 2020


Hi, Siba,

Here are my comments:

<SerializedPSSKey.java>

- Typos: Initialisation -> Initialization.

- the 2nd algorithm specific initialization using reflection doesn't 
seem too useful. The code path should be exactly the same as the 
non-reflection one. Maybe just remove it.

Rest looks fine.

Thanks,
Valerie
On 4/28/2020 12:38 AM, sibabrata.sahoo at oracle.com wrote:
> Hi Valerie,
>
> Please review the patch for,
> JBS: https://bugs.openjdk.java.net/browse/JDK-8242335
> Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/
>
> These are additional Tests developed to support RSASSA-PSS algorithm. 
> One is key compatibility with OpenSSL generated while the other one is 
> the API Tests for serialized keys.
>
> Thanks,
> Siba
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20200430/c4810744/attachment.htm>


More information about the security-dev mailing list