RFR JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
Anthony Scarpino
anthony.scarpino at oracle.com
Thu Aug 13 18:13:00 UTC 2020
On 8/11/20 9:44 AM, Xuelei Fan wrote:
> ping ...
>
> On 7/30/2020 11:26 AM, Xuelei Fan wrote:
>> Hi,
>>
>> May I get the following test code update reviewed?
>> http://cr.openjdk.java.net/~xuelei/8250839/webrev.00/
>>
>> SSLEngineTemplate is a template used for SSLEngine testing, which
>> depends on binary key store files, and not easy to extend. This
>> update makes it easier to extend, by removing the files dependency and
>> using SSLContextTemplate.
>>
>> Thanks,
>> Xuelei
Just a few nits
109-114: Did you want these commented out? I have no problem leaving
it as is. I just wanted to make sure this was your intent.
219: The whitespaces are not aligned
Otherwise it looks fine. No need for another webrev.
Tony
More information about the security-dev
mailing list