RFR JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate

Xuelei Fan xuelei.fan at oracle.com
Thu Aug 13 19:00:16 UTC 2020


All good catches!  I will update accordingly.

Thanks,
Xuelei

On 8/13/2020 11:13 AM, Anthony Scarpino wrote:
> On 8/11/20 9:44 AM, Xuelei Fan wrote:
>> ping ...
>>
>> On 7/30/2020 11:26 AM, Xuelei Fan wrote:
>>> Hi,
>>>
>>> May I get the following test code update reviewed?
>>>      http://cr.openjdk.java.net/~xuelei/8250839/webrev.00/
>>>
>>> SSLEngineTemplate is a template used for SSLEngine testing, which 
>>> depends on binary key store files, and not easy to extend.  This 
>>> update makes it easier to extend, by removing the files dependency 
>>> and using SSLContextTemplate.
>>>
>>> Thanks,
>>> Xuelei
> 
> Just a few nits
> 
> 109-114:  Did you want these  commented out?  I have no problem leaving 
> it as is.  I just wanted to make sure this was your intent.
> 
> 219:  The whitespaces are not aligned
> 
> Otherwise it looks fine.  No need for another webrev.
> 
> Tony


More information about the security-dev mailing list