RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Alexey Bakhtin alexey at azul.com
Fri Aug 14 12:41:00 UTC 2020


Hello Sean,

Thank you for review.
I’ve changed wording and replaced @code with @systemProperty (tested, it works for module-info.java)

Updated webrev at: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v15/

Regards
Alexey

> On 14 Aug 2020, at 14:50, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> On the property wording, change "for LDAP connection" to "for an LDAP connection".
> 
> Also, for the definition of the property, can you use the "@systemProperty" annotation instead of "@code"? Does that work inside the module-info.java file?
> 
> I added my name as Reviewer.
> 
> --Sean
> 
> On 7/30/20 6:14 AM, Daniel Fuchs wrote:
>> Hi Alexey,
>> I have added myself as a reviewer to the CSR [1].
>> It would be good to get someone from security-dev to do the
>> same, and then move the CSR state to "Proposed".
>> best regards,
>> -- daniel
>> [1] https://bugs.openjdk.java.net/browse/JDK-8247311
>> On 30/07/2020 10:17, Alexey Bakhtin wrote:
>>> Gentle ping
>>> 
>>> Regards
>>> Alexey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20200814/bba69e33/signature.asc>


More information about the security-dev mailing list