RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Sean Mullan sean.mullan at oracle.com
Fri Aug 14 13:18:54 UTC 2020


On 8/14/20 8:41 AM, Alexey Bakhtin wrote:
> Hello Sean,
> 
> Thank you for review.
> I’ve changed wording and replaced @code with @systemProperty (tested, it works for module-info.java)

Thanks. Now that you know it works, I think you should change the other 
properties documented in that file to @systemProperty to be consistent. 
I think it is fine to do that as part of this fix.

--Sean

> 
> Updated webrev at: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v15/
> 
> Regards
> Alexey
> 
>> On 14 Aug 2020, at 14:50, Sean Mullan <sean.mullan at oracle.com> wrote:
>>
>> On the property wording, change "for LDAP connection" to "for an LDAP connection".
>>
>> Also, for the definition of the property, can you use the "@systemProperty" annotation instead of "@code"? Does that work inside the module-info.java file?
>>
>> I added my name as Reviewer.
>>
>> --Sean
>>
>> On 7/30/20 6:14 AM, Daniel Fuchs wrote:
>>> Hi Alexey,
>>> I have added myself as a reviewer to the CSR [1].
>>> It would be good to get someone from security-dev to do the
>>> same, and then move the CSR state to "Proposed".
>>> best regards,
>>> -- daniel
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8247311
>>> On 30/07/2020 10:17, Alexey Bakhtin wrote:
>>>> Gentle ping
>>>>
>>>> Regards
>>>> Alexey
> 


More information about the security-dev mailing list