RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior [v2]

[Hai-May Chao]

On Tue, 8 Dec 2020 20:24:51 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 323:
> 
>> 321:      *          the keystore data could not be stored
>> 322:      * @throws UnsupportedOperationException if the implementation
>> 323:      *          has not overridden this method
> 
> I think we should keep this more general and just say "If the implementation does not support this operation". There may be legitimate cases in which an implementation may override this method but throw UnsupportedOperationException if it doesn't support particular aspects of the LoadStoreParameter.

Good point. Fixed as suggested.

> src/java.base/share/classes/java/security/KeyStore.java line 1424:
> 
>> 1422:      * @throws    CertificateException if any of the certificates included in
>> 1423:      *          the keystore data could not be stored
>> 1424:      * @throws    UnsupportedOperationException if this method is not supported
> 
> I would change "method" to "operation" as it is a bit more consistent with the exception.

Fixed as suggested. Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1701