RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior [v2]

[Jamil Nimeh]

Some minor comments:

  * General
      o I think you can backtick the UnsupportedOperationException text
        so it shows up in monospace format.
  * Specification
      o I think text-wise the wording is fine.  IIRC don't we normally
        show the proposed changes as a diff?  Or is that just one
        acceptable format and what's done here is fine too? Either way
        the intent is clearly communicated, IMO.

I'll put myself down as a reviewer.

--Jamil

On 12/11/2020 10:37 AM, Hai-May Chao wrote:
> On Tue, 8 Dec 2020 18:52:05 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>
>>> Marked as reviewed by xuelei (Reviewer).
>> This will also require a CSR since you are making some specification changes. I'm not sure if you were trying to get this into 16, but it is probably too late to make JDK 16 since RDP is a couple of days away. You can push to 17/latest once 16 forks and CSR is approved.
> Please review the CSR (JDK-8258114) at:
> https://bugs.openjdk.java.net/browse/JDK-8258114
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/1701
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20201211/562f1ab6/attachment.htm>