RFR: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior [v2]

Fri Dec 11 20:01:56 UTC 2020

On Fri, 11 Dec 2020 19:43:41 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> Please review the CSR (JDK-8258114) at:
>> https://bugs.openjdk.java.net/browse/JDK-8258114
>
> Thanks for the review. Updated CSR to backtick the UnsupportedOperationException text. I thought about placing the diff in Specification section, but decided to keep the document change in this format which is same as our javadoc API specification. I thought it'd be more clear. I'm open to make a change if diff format is required.

It may improve the readability to have the context specification of the update.  For example, have the full specification of the method, and mark the update of the spec, and the signature of the method.  A diff is often used as it is easier to have the context in the CSR request.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1701