[JDK 15] RFR 8239979: sun/security/tools/keytool/ExtOptionCamelCase.java is not run

Rajan Halade RAJAN.HALADE at ORACLE.COM
Wed Feb 26 23:23:03 UTC 2020


Thanks! looks good.

Thanks,
Rajan

> On Feb 25, 2020, at 10:24 PM, Amy Lu <amy.lu at oracle.com> wrote:
> 
> Removed othervm: http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html <http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html>
> 
> Thanks,
> Amy
> 
> On 2/26/20 11:02 AM, Rajan Halade wrote:
>> Thanks Amy for the fix! 
>> 
>> Any reason for using othervm to run this test? Otherwise your fix looks good to me.
>> 
>> Thanks,
>> Rajan
>> 
>>> On Feb 25, 2020, at 6:48 PM, Amy Lu <amy.lu at oracle.com <mailto:amy.lu at oracle.com>> wrote:
>>> 
>>> sun/security/tools/keytool/ExtOptionCamelCase.java
>>> 
>>> This is not a compile-only test, but due to the missed @run tag, test is not run.
>>> 
>>> Please review the patch to fix this issue.
>>> 
>>> The patch also fixed @modules. Test performs deep reflection setAccessible(true) on a non-public member, `open` added to the module.
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8239979 <https://bugs.openjdk.java.net/browse/JDK-8239979>
>>> webrev: http://cr.openjdk.java.net/~amlu/8239979/webrev.00/index.html <http://cr.openjdk.java.net/~amlu/8239979/webrev.00/index.html>
>>> 
>>> Thanks,
>>> Amy
>>> 
>>> 
>>>  --- old/test/jdk/sun/security/tools/keytool/ExtOptionCamelCase.java	2020-02-26 10:36:19.000000000 +0800
>>> +++ new/test/jdk/sun/security/tools/keytool/ExtOptionCamelCase.java	2020-02-26 10:36:18.000000000 +0800
>>> @@ -1,5 +1,5 @@
>>>  /*
>>> - * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
>>> + * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>   *
>>>   * This code is free software; you can redistribute it and/or modify it
>>> @@ -24,11 +24,13 @@
>>>  /*
>>>   * @test
>>>   * @bug 8231950
>>> + * @summary keytool -ext camel-case shorthand not working
>>>   * @modules java.base/sun.security.tools.keytool
>>> + *          java.base/sun.security.tools.keytool:open
>>>   *          java.base/sun.security.util
>>>   *          java.base/sun.security.x509
>>>   * @compile -XDignore.symbol.file ExtOptionCamelCase.java
>>> - * @summary keytool -ext camel-case shorthand not working
>>> + * @run main/othervm ExtOptionCamelCase
>>>   */
>>>  
>>>  import sun.security.tools.keytool.Main;
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20200226/81a9db4d/attachment-0001.htm>


More information about the security-dev mailing list