RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

[Rajan Halade]

Hi John,

Thanks for taking care of this fix. Your changes look good me. 

I have couple of suggestions:

- consider changing header for last column from “Why negative case” to “Reason”
- for a failed test case (a testcase that succeeds when expected to fail or a testcase that fails when expected to succeed) code will not have any reason listed and we will need to click hyperlink in the report to find out root cause. May I suggest to pass in status to TestCase.negativeCaseReason() method call and use reason as “Refer to log at test hyperlink for details…” for such cases.

Thanks,
Rajan

> On Mar 24, 2020, at 6:50 PM, sha.jiang at oracle.com wrote:
> 
> Hi,
> This patch updates the manual test javax/net/ssl/compatibility/Compatibility.java on the following points:
> 1. Covers SSLv3
> 2. The server side doesn't limit/specify protocols and cipher suites anymore. Only the client side specifies these parameters.
> 3. Only focus on the testing JDK specified by jtreg option "-jdk", and not run the cases between the JDKs builds in jdkList. This would save much execution time.
> 4. The report has a new column that clarifying why a case is a negative case.
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-8237977
> Webrev: http://cr.openjdk.java.net/~jjiang/8237977/webrev.00/
> 
> Best regards,
> John Jiang
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20200324/3caae7b7/attachment.htm>