[15] RFR: 8242335: Additional Tests for RSASSA-PSS

[sibabrata.sahoo at oracle.com]

Hi Valerie,

Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature instance.

Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/ <http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/>

Thanks,
Siba



> On 01-May-2020, at 4:58 AM, Valerie Peng <valerie.peng at oracle.com> wrote:
> 
> Hi, Siba,
> 
> Here are my comments:
> 
> <SerializedPSSKey.java>
> 
> - Typos: Initialisation -> Initialization.
> 
> - the 2nd algorithm specific initialization using reflection doesn't seem too useful. The code path should be exactly the same as the non-reflection one. Maybe just remove it.
> 
> Rest looks fine.
> 
> Thanks,
> Valerie
> On 4/28/2020 12:38 AM, sibabrata.sahoo at oracle.com <mailto:sibabrata.sahoo at oracle.com> wrote:
>> Hi Valerie,
>> 
>> Please review the patch for,
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8242335 <https://bugs.openjdk.java.net/browse/JDK-8242335>
>> Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/ <http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/>
>> 
>> These are additional Tests developed to support RSASSA-PSS algorithm. One is key compatibility with OpenSSL generated while the other one is the API Tests for serialized keys.
>> 
>> Thanks,
>> Siba
>> 
>> 
>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20200504/8532cb1a/attachment.htm>