RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

[Valerie Peng]

On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Xuelei comments

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 432:

> 430:     // For input it takes the ibuffer which is wrapped in 'buffer' and 'src'
> 431:     // from doFinal.
> 432:     void doLastBlock(ByteBuffer buffer, ByteBuffer src, ByteBuffer dst)

The ordering of these new ByteBuffer-arg methods seems random? Perhaps, either group them altogether or move them so
that they are together with the byte[] counterpart methods?

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 508:

> 506:     }
> 507:
> 508:     int decrypt(ByteBuffer src, ByteBuffer dst) {

Similar to above. It seems a bit strange to see decrypt(...) method in between encrypt(...) methods.

-------------

PR: https://git.openjdk.java.net/jdk/pull/411