RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

Valerie Peng valeriep at openjdk.java.net
Fri Oct 9 00:45:27 UTC 2020


On Thu, 8 Oct 2020 06:51:08 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Xuelei comments

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 545:

> 543:                         "Unable to add remaining input to the buffer", e);
> 544:                 }
> 545:             }

Existing usage for ibuffer is only for decryption. If you are storing into ibuffer for encryption, the comment about it
should be updated. The earlier code in this method should also check ibuffer and if non-empty, apply its content before
applying src?

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list