RFR: 8253821: Improve ByteBuffer performance with GCM [v2]
Anthony Scarpino
ascarpino at openjdk.java.net
Fri Oct 9 01:55:25 UTC 2020
On Fri, 9 Oct 2020 00:42:57 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 545:
>
>> 543: "Unable to add remaining input to the buffer", e);
>> 544: }
>> 545: }
>
> Existing usage for ibuffer is only for decryption. If you are storing into ibuffer for encryption, the comment about it
> should be updated. The earlier code in this method should also check ibuffer and if non-empty, apply its content before
> applying src?
I updated the comment. I had redone this method before your comment. Take a look at that on the next webrev
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
More information about the security-dev
mailing list