RFR: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size [v4]

Lance Andersen lancea at openjdk.java.net
Tue Oct 13 18:53:24 UTC 2020


On Tue, 13 Oct 2020 18:46:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Volker Simonis has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains one commit:
>>   8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size
>
> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 85:
> 
>> 83:      * ZipEntry#setCompressedSize(long)} method, then the compressed
>> 84:      * size will be set to the actual compressed size after deflation.
>> 85:      * <p>
> 
> I'm happy with the wording. What you think about put a p tag before "The default compression method ..." so that it
> goes into its own paragraph? I'm asking because it's inconsistent to have the first paragraph include the details on
> the compression method and the details on the current time pushed into a second paragraph - if you generate the javadoc
> then you'll see what I mean.

I think that is a good idea to at the paragraph tag as you suggest

-------------

PR: https://git.openjdk.java.net/jdk/pull/520



More information about the security-dev mailing list