RFR: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size [v4]

Volker Simonis simonis at openjdk.java.net
Tue Oct 13 19:07:37 UTC 2020


On Tue, 13 Oct 2020 18:50:00 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 87:
>> 
>>> 85:      * <p>
>>> 86:      * The current time will be used if the entry has no set modification
>>> 87:      * time.
>> 
>> I'm happy with the wording. What you think about put a p tag before "The default compression method ..." so that it
>> goes into its own paragraph? I'm asking because it's inconsistent to have the first paragraph include the details on
>> the compression method and the details on the current time pushed into a second paragraph - if you generate the javadoc
>> then you'll see what I mean.
>
> I think that is a good idea to at the paragraph tag as you suggest

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/520



More information about the security-dev mailing list