RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

[Paul Sandoz]

On Thu, 22 Oct 2020 14:31:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/invoke/NativeMethodHandle.java line 36:
>> 
>>> 34: import static java.lang.invoke.MethodHandleStatics.newInternalError;
>>> 35: 
>>> 36: /** TODO */
>> 
>> Is the TODO to make this class public later and adjust the return type of `downcallHandle`?
>
> IIRC this was added to silence a javac linter warning. Something should be added here. There is/was no plan to make this class public though.

It's odd the lint warning is triggering on a package private class and private methods. Separately, I recommend updating `make/CompileJavaModules.gmk` and adding `-Xdoclint:all/protected` for the module (i recently did this for the vector API see [here](https://github.com/openjdk/jdk/commit/000143504408ac7938e9f493c17c4dbb994045f9#diff-118e609b9974c0ce8af7950711461c7ab4620c9d4f4c99d231f598696f8e05d0)

-------------

PR: https://git.openjdk.java.net/jdk/pull/634