RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

Thu Oct 22 16:34:28 UTC 2020

On Thu, 22 Oct 2020 15:46:33 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> IIRC this was added to silence a javac linter warning. Something should be added here. There is/was no plan to make this class public though.
>
> It's odd the lint warning is triggering on a package private class and private methods. Separately, I recommend updating `make/CompileJavaModules.gmk` and adding `-Xdoclint:all/protected` for the module (i recently did this for the vector API see [here](https://github.com/openjdk/jdk/commit/000143504408ac7938e9f493c17c4dbb994045f9#diff-118e609b9974c0ce8af7950711461c7ab4620c9d4f4c99d231f598696f8e05d0)

There's no lint warning for private method, a fix is coming. As for makefile changes, I'd prefer to postpone after integration, or add them to the foreign memory access PR, since that's not specific to this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/634