RFR: 8253821: Improve ByteBuffer performance with GCM [v2]
Anthony Scarpino
ascarpino at openjdk.java.net
Thu Oct 22 18:05:21 UTC 2020
On Mon, 12 Oct 2020 18:45:28 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 237:
>
>> 235: encrypt(in, offset, processed, out, 0);
>> 236: dst.get(out, 0, processed);
>> 237: return len;
>
> This block of code looks strange?
> len = inLen % AES_BLOCK_SIZE => len must be between 0...AES_BLOCK_SIZE-1, I think you meant to use len = (inLen - inLen% AES_BLOCK_SIZE)
> dst.get(...) should be dst.put(...)
Ok. Not surprising no test failed given it's a rollover situation
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
More information about the security-dev
mailing list