RFR: 8253821: Improve ByteBuffer performance with GCM [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Thu Oct 22 18:08:19 UTC 2020


On Mon, 12 Oct 2020 18:26:14 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 165:
> 
>> 163:     }
>> 164: 
>> 165:     int update(ByteBuffer src, ByteBuffer dst) {
> 
> Based on the impl in GaloisCounterMode, this is only called when src.remaining() >= 128. Perhaps documenting the conditions here as there are no checks on the src/dst sizes as in the byte[] case.

Sounds good

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list