RFR: 8172366: Support SHA-3 based signatures

Valerie Peng valeriep at openjdk.java.net
Mon Sep 14 21:04:38 UTC 2020


On Thu, 10 Sep 2020 16:46:52 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Could someone please help review this RFE?
>> 
>> Enhance default JDK providers except SunPKCS11 with signatures using SHA-3 family of digests. SunPKCS11 provider will
>> be updated separately (JDK-8242332).
>> This changes covers SUN, SunRsaSign, and SunEC providers. Changes are straightforward, just add SHA-3 digests to
>> various signature algorithms.
>> Please review the corresponding CSR as well. It's at: https://bugs.openjdk.java.net/browse/JDK-8252260
>> 
>> Thanks!
>> Valerie
>
> src/java.base/share/classes/sun/security/provider/DSA.java line 514:
> 
>> 512:         }
>> 513:     }
>> 514:     public static final class SHA3_224withDSAinP1363Format extends DSA {
> 
> Missed the blank line.
> 
> BTW, to be consistent with other styles, do you want to add class specs (/**-*/) for the new added classes? just like
> what you did for SHA512withDSAinP1363Format.

Ok.

-------------

PR: https://git.openjdk.java.net/jdk/pull/102



More information about the security-dev mailing list