RFR: 8172366: Support SHA-3 based signatures [v4]

Valerie Peng valeriep at openjdk.java.net
Tue Sep 15 01:42:35 UTC 2020


On Thu, 10 Sep 2020 17:12:45 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update DSA.java
>>   
>>   Removed the trailing white spaces in previous update.
>
> src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java line 279:
> 
>> 277:         if (key != null) {
>> 278:             try {
>> 279:                 int hLen = DIGEST_LENGTHS.get(KnownOIDs.findMatch(digestAlgo));
> 
> Is it possible the disgestAlgo unknown, and result in NullPointerException while casting null to int?  I think it is
> safe to check the existence as you did in line 218-213.

Sure, will update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/102



More information about the security-dev mailing list