RFR: 8264208: Console charset API [v2]

Alan Bateman alanb at openjdk.java.net
Sun Apr 11 13:47:43 UTC 2021


On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Please review the changes for the subject issue.  This has been suggested in a recent discussion thread for the JEP 400 [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. A CSR has also been drafted, and comments are welcome [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reflected the review comments.

src/java.base/share/classes/java/io/Console.java line 397:

> 395:     /**
> 396:      * Returns the {@link java.nio.charset.Charset Charset} object used in
> 397:      * this {@code Console}.

The Console is a singleton and the existing methods use "the console" so I think we should do the same here.

We'll need to add to the description of the System.{in,out,err} fields, I don't mind if we do it as part of this PR or another issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3419



More information about the security-dev mailing list