RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

Sibabrata Sahoo ssahoo at openjdk.java.net
Thu Apr 15 10:30:35 UTC 2021


On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Could someone (perhaps Jamil?) please help review this change? This enhances SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation support. Majority of the regression tests are adapted from the existing ones for SunJCE provider's ChaCha20-Poly1305 cipher impl. When testing against NSS v3.57, it does not have support for ChaCha20 cipher, thus I did not add support for ChaCha20 cipher and the corresponding parameter.
>> 
>> Thanks!
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed an tagLen issue, no key+iv reuse check for decryption, and add regression test for ChaCha20 SKF.

test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java line 1:

> 1: /*

There is no compatibility Test exist between SunJCE and SunPKCS11 providers. Do we need one here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3420



More information about the security-dev mailing list