[jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v2]
Aleksey Shipilev
shade at openjdk.java.net
Thu Dec 23 16:31:03 UTC 2021
> SonarCloud reports:
> A "Map<ServiceKey, Service>" cannot contain a "String" in a "ServiceKey" type.
>
>
> // clean up old alias if present
> Service prevAliasService = legacyMap.get(aliasAlg);
>
>
> Should be `aliasKey`, like other accesses to `legacyMap`. This code is introduced by [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it affects JDK 18.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug `jdk_security`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'master' into JDK-8279222-jsp-get
- Fix
-------------
Changes:
- all: https://git.openjdk.java.net/jdk18/pull/70/files
- new: https://git.openjdk.java.net/jdk18/pull/70/files/4fccd981..9c6af4bb
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=70&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=70&range=00-01
Stats: 625 lines in 42 files changed: 341 ins; 186 del; 98 mod
Patch: https://git.openjdk.java.net/jdk18/pull/70.diff
Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/70/head:pull/70
PR: https://git.openjdk.java.net/jdk18/pull/70
More information about the security-dev
mailing list