[jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Dec 24 11:50:25 UTC 2021


On Thu, 23 Dec 2021 21:06:51 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Hmm, this "ADD" case should be covered by existing regression tests. I will take a look. Thanks.
>
> Hmm, existing test does add an alias, the legacyMap.get() would returns null upon 'aliasAlg' (type: String). To test this particular scenario, I enhanced existing regression test to re-assign an alias and then check if the returned impl is as expected. The proposed test patch is attached. If we are including this test patch into this PR, then good to add the bug id to the test too.
> [patch.txt](https://github.com/openjdk/jdk18/files/7771389/patch.txt)

Thanks, @valeriepeng! Do you see the current JDK 18 failing with that test addition? Because this still passes for me without the fix from this PR: `CONF=linux-x86_64-server-fastdebug make run-test TEST=java/security/Provider/CaseSensitiveServices.java`

-------------

PR: https://git.openjdk.java.net/jdk18/pull/70



More information about the security-dev mailing list