RFR: 8258915: Temporary buffer cleanup [v8]

Valerie Peng valeriep at openjdk.java.net
Thu Feb 18 11:11:41 UTC 2021


On Sat, 6 Feb 2021 14:40:04 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Clean up temporary byte array, char array, and keyspec around keys and passwords.
>> 
>> No new regression test.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   materials

Other files look fine. Thanks~

src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java line 261:

> 259:                     md5.update(clientRandom);
> 260:                     md5.update(serverRandom);
> 261:                     digest = md5.digest();

In other Tls* sources, you call MessageDigest.reset() but not here? Particular reason?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2070


More information about the security-dev mailing list