RFR: 8258915: Temporary buffer cleanup [v8]

Weijun Wang weijun at openjdk.java.net
Thu Feb 18 19:21:42 UTC 2021


On Thu, 18 Feb 2021 11:08:06 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   materials
>
> src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java line 261:
> 
>> 259:                     md5.update(clientRandom);
>> 260:                     md5.update(serverRandom);
>> 261:                     digest = md5.digest();
> 
> In other Tls* sources, you call MessageDigest.reset() but not here? Particular reason?

I usually call it when the last updated bytes are sensitive. They will stay in the buffer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2070


More information about the security-dev mailing list