RFR: 8259385: Cleanup unused assignment [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Sun Jan 10 21:20:11 UTC 2021


On Sun, 10 Jan 2021 19:52:24 GMT, Attila Szegedi <attila at openjdk.org> wrote:

> LGTM. Looks like a good ol' IntelliJ IDEA driven fixing (nothing wrong with that.)
Right.

> Maybe you could also fix those "temproary" typos while in there?
Updated.  Thanks!

> FWIW, 2 of 3 occurrences of code containing them are almost entirely equivalent and could be refactored into a static method with a Supplier<byte[]> that produces the digest, but I guess it'd be worth filing a separate issue for that.
I will make more evaluation if a new issue could be filed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1984



More information about the security-dev mailing list