RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Tue Jul 6 18:35:54 UTC 2021


On Tue, 6 Jul 2021 15:41:27 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merge AESGCMByteArray with existing AESGCMBench
>
> test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java line 58:
> 
>> 56:     SecretKeySpec ks;
>> 57:     GCMParameterSpec gcm_spec;
>> 58:     byte[] aad;
> 
> Not an expert on this, but why no more AAD?

For a performance test there isn't any value in adding an AAD.  It's data sitting in a buffer that an be easily replicated with a multipart operation

-------------

PR: https://git.openjdk.java.net/jdk/pull/4672



More information about the security-dev mailing list