RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Tue Jul 6 18:47:53 UTC 2021


On Tue, 6 Jul 2021 15:38:20 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merge AESGCMByteArray with existing AESGCMBench
>
> test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java line 46:
> 
>> 44:     private int keyLength;
>> 45: 
>> 46:     @Param({"" + 1024, "" +  1500, "" + 4096, "" + 16384})
> 
> Now that you don't calculate anymore, how about just string literals like `"1024"` etc?

Funny.. I didn't even notice that

-------------

PR: https://git.openjdk.java.net/jdk/pull/4672



More information about the security-dev mailing list