RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

[Mandy Chung]

On Wed, 23 Jun 2021 03:54:55 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tests rely on IOOBE exception message

I suggest to separate the client changes (both src and test) in a separate PR for the client review.

I review the rest of the files, which looks okay to me.   I will take another pass carefully.

src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java needs to be updated in JSR 166 upstream repo.    Better to file a separate issue for this change to ensure that gets fixed in the upstream project.

test/jdk/java/lang/StringBuffer/Exceptions.java line 73:

> 71:                 new StringBuffer();
> 72:             }
> 73:         });

Nit: The above formatting (line 70-97) is inconsistent with the formatting in line 110-124.   It'd be good to use the same formatting.

test/jdk/java/lang/StringBuilder/Exceptions.java line 73:

> 71:                 new StringBuilder();
> 72:             }
> 73:         });

Nit: it'd be good to make the formatting of all calls to tryCatch method consistent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4507