RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v8]

[Yi Yang]

On Tue, 6 Jul 2021 19:06:43 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tests rely on IOOBE exception message
>
> test/jdk/java/lang/StringBuffer/Exceptions.java line 73:
> 
>> 71:                 new StringBuffer();
>> 72:             }
>> 73:         });
> 
> Nit: The above formatting (line 70-97) is inconsistent with the formatting in line 110-124.   It'd be good to use the same formatting.

Hi Mandy, thanks for reviewing this. 

> I suggest to separate the client changes (both src and test) in a separate PR for the client review.

Does "client changes" means changes involving src/java.desktop and test/java/awt?

> src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java needs to be updated in JSR 166 upstream repo. Better to file a separate issue for this change to ensure that gets fixed in the upstream project.

Can you please paste a link for that? I'm not sure where I can find JSR 166 upstream repo..

> Nit: The above formatting (line 70-97) is inconsistent with the formatting in line 110-124. It'd be good to use the same formatting.

Restored.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4507