RFR: 8270317: Large Allocation in CipherSuite [v5]

Clive Verghese cverghese at openjdk.java.net
Fri Jul 23 17:11:33 UTC 2021


On Fri, 23 Jul 2021 17:05:58 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Clive Verghese has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove for loop from validValuesOf
>
> src/java.base/share/classes/sun/security/ssl/CipherSuite.java line 972:
> 
>> 970:             boolean found = false;
>> 971:             CipherSuite cs;
>> 972:             if ((cs = cipherSuiteNames.get(name)) != null && !cs.supportedProtocols.isEmpty()) {
> 
> Nice update!  I appreciate if you could avoid lines longer than 80 characters, since they’re not handled well by many terminals and tools (See [Java Code Conventions](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html)).

Thank you @XueleiFan, Updated the length of the line.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4783



More information about the security-dev mailing list