RFR: 8270317: Large Allocation in CipherSuite [v5]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Fri Jul 23 17:49:03 UTC 2021


On Fri, 23 Jul 2021 17:08:11 GMT, Clive Verghese <cverghese at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/CipherSuite.java line 972:
>> 
>>> 970:             boolean found = false;
>>> 971:             CipherSuite cs;
>>> 972:             if ((cs = cipherSuiteNames.get(name)) != null && !cs.supportedProtocols.isEmpty()) {
>> 
>> Nice update!  I appreciate if you could avoid lines longer than 80 characters, since they’re not handled well by many terminals and tools (See [Java Code Conventions](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html)).
>
> Thank you @XueleiFan, Updated the length of the line.

Thank you for the update.  This PR looks good to me, and I have no further comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4783



More information about the security-dev mailing list