RFR: 8255148: Confusing log output: SSLSocket duplex close failed
Sean Mullan
mullan at openjdk.java.net
Fri Jun 4 14:11:57 UTC 2021
On Fri, 4 Jun 2021 10:44:32 GMT, Evan Whelan <ewhelan at openjdk.org> wrote:
> Hi,
>
> Please review my fix for JDK-8255148 which clarifies when an exception contains debug information only.
>
> Regards,
> Evan
src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 590:
> 588: // ignore the exception
> 589: if (SSLLogger.isOn && SSLLogger.isOn("ssl")) {
> 590: SSLLogger.warning("SSLSocket duplex close failed. Debug info only. Exception details:", ioe);
If this is a debug message, shouldn't we just use `SSLLogger.fine()` instead of `SSLLogger.warning()`, with the same message "SSLSocket duplex close failed"? @coffeys what do you think?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4354
More information about the security-dev
mailing list