RFR: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Aleksey Shipilev shade at openjdk.java.net
Wed Jun 23 07:45:36 UTC 2021


SonarCloud reports:
"Remove or correct this useless self-assignment."


        if (cipherAlgo.equals("AES")) {
            this.keysize = keysize; // <---- here
            switch (keysize) {
            case 128:
                cipherAlgo_OID = aes128CBC_OID;


Seems to be here since initial addition in JDK-6383200.

Additional testing:
 - [x] `jdk_security` pass

-------------

Commit messages:
 - 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Changes: https://git.openjdk.java.net/jdk/pull/4570/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4570&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8269216
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4570.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4570/head:pull/4570

PR: https://git.openjdk.java.net/jdk/pull/4570



More information about the security-dev mailing list