RFR: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java
Valerie Peng
valeriep at openjdk.java.net
Wed Jun 23 16:52:35 UTC 2021
On Wed, 23 Jun 2021 07:38:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> SonarCloud reports:
> "Remove or correct this useless self-assignment."
>
>
> if (cipherAlgo.equals("AES")) {
> this.keysize = keysize; // <---- here
> switch (keysize) {
> case 128:
> cipherAlgo_OID = aes128CBC_OID;
>
>
> Seems to be here since initial addition in JDK-6383200.
>
> Additional testing:
> - [x] `jdk_security` pass
Changes look good. I also added the noreg-cleanup label to the bug record.
-------------
Marked as reviewed by valeriep (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4570
More information about the security-dev
mailing list