RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

Anton Kozlov akozlov at openjdk.java.net
Tue Mar 2 07:48:36 UTC 2021

On Mon, 15 Feb 2021 17:59:54 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 810:
>>> 808: #ifdef __APPLE__
>>> 809:           // Less-than word types are stored one after another.
>>> 810:           // The code unable to handle this, bailout.
>> Perhaps:  // The code is unable to handle this so bailout.
> Hello, we have updated PR, now this bailout is used only by the code which can handle it (native wrapper generator), for the rest it will cause guarantee failed if this bailout is triggered

I've fixed the spelling. Sorry for it to take so long :(

>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 195:
>>> 193: frame os::get_sender_for_C_frame(frame* fr) {
>>> 194:   return frame(fr->link(), fr->link(), fr->sender_pc());
>>> 195: }
>> Is this file going to be built by GCC or just macOS compilers?
> there is no support for compiling java with gcc on macos since about jdk11, only clang.
> considering this and the absence of gcc for macos_m1, the answer is - just macOS compilers.

I've fixed the comment. Now it states `JVM compiled with -fno-omit-frame-pointer, so RFP is saved on the stack.`


PR: https://git.openjdk.java.net/jdk/pull/2200

More information about the security-dev mailing list