RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v2]

Evan Whelan ewhelan at openjdk.java.net
Tue Mar 2 15:08:01 UTC 2021


> Hi all,
> 
> Please review my test fix relating to JDK-8262438
> 
> This patch introduces as Thread.sleep at the start of each iteration which creates a new test jvm. 
> This allows the server socket sufficient time to release the previous connection and allows the port to be used again.
> 
> I also refactored the behaviour for when the exitCode is not 0, allowing for an easier to read output.
> An incorrect HttpsUrlConnection.disconnect() was also removed.
> 
> The test was ran 100 times on all platforms and no failures were seen. 
> 
> Thanks,
> Evan

Evan Whelan has updated the pull request incrementally with two additional commits since the last revision:

 - 8262438: Stream operations on new lines
 - 8262438: Ensure all streams are emptied in socket connection

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2749/files
  - new: https://git.openjdk.java.net/jdk/pull/2749/files/363466f8..ae1acb21

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2749&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2749&range=00-01

  Stats: 22 lines in 1 file changed: 12 ins; 4 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2749.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2749/head:pull/2749

PR: https://git.openjdk.java.net/jdk/pull/2749



More information about the security-dev mailing list