RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v2]

Evan Whelan ewhelan at openjdk.java.net
Thu Mar 4 09:59:54 UTC 2021

On Tue, 2 Mar 2021 15:13:56 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Evan Whelan has updated the pull request incrementally with two additional commits since the last revision:
>>  - 8262438: Stream operations on new lines
>>  - 8262438: Ensure all streams are emptied in socket connection
> test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 133:
>> 131:             out.flush();
>> 132:         } finally {
>> 133:             socket.getInputStream().readAllBytes();
> This will cause the server side to block until the client closes the socket. Is that what you really want to do? (It may be - but if the client is a regular HTTP client (HttpURLConnection / HttpClient) it will not close the connection until its keep-alive delay (may be up to 20mins) is expired.

I've updated the PR by removing the custom server logic, more detail can be found in my latest comment.

Evan :)


PR: https://git.openjdk.java.net/jdk/pull/2749

More information about the security-dev mailing list