RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java [v2]

Fernando Guallini fguallini at openjdk.java.net
Thu Mar 4 15:56:59 UTC 2021


On Thu, 4 Mar 2021 13:42:57 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move set env properties to header
>
> test/jdk/sun/security/krb5/canonicalize/Test.java line 37:
> 
>> 35:     public static void main(String[] args) throws Exception {
>> 36:         // This config file is generated using Kerberos.app on a Mac
>> 37:         System.setProperty("java.security.krb5.realm", "THIS.REALM");
> 
> Maybe, you can move setting of `java.security.krb5.realm` and `java.security.krb5.kdc` properties to the `jtreg` header to have consistent approach of setting properties needed for a test run.

Agree. Updated in latest commit, thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/2809


More information about the security-dev mailing list