RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes [v3]

Anthony Scarpino ascarpino at openjdk.java.net
Wed Mar 17 21:06:49 UTC 2021


On Wed, 17 Mar 2021 20:13:43 GMT, SalusaSecondus <github.com+829871+SalusaSecondus at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed a null race condition
>
> Not that my review counts towards approval, but this looks good to me (and fixes some issues I've been wrestling with on and off for several years now, so I'm really happy to see this change).

I'm fine with the change.  The main code path should perform as it did previous to the change and I don't think the lock here is a big deal as it will only be triggered during a provider change.  One small delay in a very rare case should be fine

-------------

PR: https://git.openjdk.java.net/jdk/pull/3018



More information about the security-dev mailing list