RFR: 8263658: Use the blessed modifier order in java.base

Aleksey Shipilev shade at openjdk.java.net
Thu Mar 18 15:10:38 UTC 2021


On Wed, 17 Mar 2021 12:31:22 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Sonar displays a warning message that modifiers should be declared in the order listed in the JLS; specifically, that isntead of using `final static` the `static final` should be preferred.
>> 
>> This fixes the issues in the `java.base` package for ease of reviewing.
>> 
>> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&resolved=false&rules=java%3AS1124
>
> src/java.base/share/classes/com/sun/security/ntlm/NTLMException.java line 52:
> 
>> 50:      * from server.
>> 51:      */
>> 52:     //public static final int DOMAIN_UNMATCH = 3;
> 
> Maybe this one ought to be removed instead?

Yeah, I agree.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2993


More information about the security-dev mailing list