Integrated: 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling

Anthony Scarpino ascarpino at openjdk.java.net
Thu Mar 25 19:23:30 UTC 2021


On Sat, 20 Feb 2021 04:25:50 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a code review of this change to ECDH.  It is a combination of fixing the implementation to not only accept ECPrivateKeyImpl along with a fix to the exception handling.  They started as two fixes, but with the exception handling the underlying code changed significantly that made the ECPrivateKey change in a different place.  The new exception handling is a result of no longer having the native library.  Many of the checks waited until generateSecret() to send the keys to the native library. Now that native is gone, checks can happen when keys are provided to the methods and proper exceptions can be thrown instead of wrapping everything as a ProviderException
> 
> thanks,
> 
> Tony

This pull request has now been integrated.

Changeset: 374272fd
Author:    Anthony Scarpino <ascarpino at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/374272fd
Stats:     203 lines in 2 files changed: 137 ins; 32 del; 34 mod

8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling

Reviewed-by: jnimeh

-------------

PR: https://git.openjdk.java.net/jdk/pull/2659


More information about the security-dev mailing list