RFR: 8248268: Support KWP in addition to KW [v3]

Valerie Peng valeriep at openjdk.java.net
Fri Mar 26 21:41:30 UTC 2021


On Tue, 23 Mar 2021 19:06:30 GMT, Greg Rubin <github.com+829871+SalusaSecondus at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed AlgorithmParameters impls to register under AES/KW/NoPadding and
>>   AES/KWP/NoPadding
>
> src/java.base/share/classes/com/sun/crypto/provider/KWUtil.java line 87:
> 
>> 85:      */
>> 86:     static final void W_INV(byte[] in, int inLen, byte[] ivOut,
>> 87:             SymmetricCipher cipher) {
> 
> The asymmetry between `W` not taking an IV but `W_INV` returning an IV also bothers me and seems to make this harder to use safely.

Ok, I can update to make W() handles the IV semiblock overwrite.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2404


More information about the security-dev mailing list