RFR: 8240256: Better resource cleaning for SunPKCS11 Provider
Valerie Peng
valeriep at openjdk.java.net
Mon May 3 19:06:51 UTC 2021
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey <coffeys at openjdk.org> wrote:
> Added capability to allow the PKCS11 Token to be destroyed once a session is logged out from. New configuration properties via pkcs11 config file. Cleaned up the native resource poller also.
>
> New unit test case to test behaviour. Some PKCS11 tests refactored to allow pkcs11 provider to be configured (and tested) with a config file of choice.
>
> Reviewer request @valeriepeng
test/jdk/sun/security/pkcs11/PKCS11Test.java line 555:
> 553: }
> 554: p = getSunPKCS11(nssConfig);
> 555: test.premain(p);
It seems a bit strange that the 2nd argument p isn't really used, but rather overridden with getSunPKCS11(String config) call. Do you mean to call getSunPKCS11(nssConfig, p) here if p is non-null?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3544
More information about the security-dev
mailing list