RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

Valerie Peng valeriep at openjdk.java.net
Tue May 4 00:59:52 UTC 2021


On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Added capability to allow the PKCS11 Token to be destroyed once a session is logged out from. New configuration properties via pkcs11 config file. Cleaned up the native resource poller also.
> 
> New unit test case to test behaviour. Some PKCS11 tests refactored to allow pkcs11 provider to be configured (and tested) with a config file of choice.
> 
> Reviewer request @valeriepeng

test/jdk/sun/security/pkcs11/Provider/Login.java line 52:

> 50:         }
> 51:         System.out.println("Finish: "+ weakRef.refersTo(null));
> 52:     }

What is this particular block of code for? main(Provider) is non-static and may be called more than once, but then you store the passed-in Provider object into a static field? Also, must the static field use type SunPKCS11? It seems AuthProvider is sufficient and most of the "ap->pkcs11Provider" changes can be avoided?

test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 2:

> 1: /*
> 2:  * Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights reserved.

New file, should just be 2021?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3544



More information about the security-dev mailing list